Revert the patch from 2003/Sep/12. This kept DnD in tree views within

2004-06-07  Federico Mena Quintero  <federico@ximian.com>

	* gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
	from 2003/Sep/12.  This kept DnD in tree views within modal
	dialogs from working, which is especially bad for the file
	chooser.  Fixes #135168.

diff --git a/ChangeLog b/ChangeLog
index fa35ebe0e432071f854c73a201bf8c665d6a3c1c..2135adb8bc70691198aaf09e0984ef96ad9519c7 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2004-06-07  Federico Mena Quintero  <federico@ximian.com>
+
+       * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
+       from 2003/Sep/12.  This kept DnD in tree views within modal
+       dialogs from working, which is especially bad for the file
+       chooser.  Fixes #135168.
+
 Sun Jun  6 23:57:21 2004  Matthias Clasen  <maclas@gmx.de>
 
        Make the entry context menu work in editable text cells. The changes are

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index fa35ebe0e432071f854c73a201bf8c665d6a3c1c..2135adb8bc70691198aaf09e0984ef96ad9519c7 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,10 @@
+2004-06-07  Federico Mena Quintero  <federico@ximian.com>
+
+       * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
+       from 2003/Sep/12.  This kept DnD in tree views within modal
+       dialogs from working, which is especially bad for the file
+       chooser.  Fixes #135168.
+
 Sun Jun  6 23:57:21 2004  Matthias Clasen  <maclas@gmx.de>
 
        Make the entry context menu work in editable text cells. The changes are

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index fa35ebe0e432071f854c73a201bf8c665d6a3c1c..2135adb8bc70691198aaf09e0984ef96ad9519c7 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,10 @@
+2004-06-07  Federico Mena Quintero  <federico@ximian.com>
+
+       * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
+       from 2003/Sep/12.  This kept DnD in tree views within modal
+       dialogs from working, which is especially bad for the file
+       chooser.  Fixes #135168.
+
 Sun Jun  6 23:57:21 2004  Matthias Clasen  <maclas@gmx.de>
 
        Make the entry context menu work in editable text cells. The changes are

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index fa35ebe0e432071f854c73a201bf8c665d6a3c1c..2135adb8bc70691198aaf09e0984ef96ad9519c7 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,10 @@
+2004-06-07  Federico Mena Quintero  <federico@ximian.com>
+
+       * gtk/gtktreeview.c (gtk_tree_view_button_press): Revert the patch
+       from 2003/Sep/12.  This kept DnD in tree views within modal
+       dialogs from working, which is especially bad for the file
+       chooser.  Fixes #135168.
+
 Sun Jun  6 23:57:21 2004  Matthias Clasen  <maclas@gmx.de>
 
        Make the entry context menu work in editable text cells. The changes are

diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c
index f709820eb677d1e8ad216c7947c109b90564c6e8..0c345981a3c769fedf74effb3a32ddefbe4bf73f 100644 (file)
--- a/gtk/gtktreeview.c
+++ b/gtk/gtktreeview.c
@@ -2114,7 +2114,6 @@ gtk_tree_view_button_press (GtkWidget      *widget,
       gint column_handled_click = FALSE;
       gboolean row_double_click = FALSE;
       gboolean rtl;
-      GtkWidget *grab_widget;
 
       /* are we in an arrow? */
       if (tree_view->priv->prelight_node &&
@@ -2320,9 +2319,7 @@ gtk_tree_view_button_press (GtkWidget      *widget,
 
       /* Save press to possibly begin a drag
        */
-      grab_widget = gtk_grab_get_current ();
-      if ((grab_widget == NULL || grab_widget == widget) &&
-          !column_handled_click &&
+      if (!column_handled_click &&
          tree_view->priv->pressed_button < 0)
         {
           tree_view->priv->pressed_button = event->button;